- 
                Notifications
    
You must be signed in to change notification settings  - Fork 2.1k
 
[Secret Hiding] Add Linux patches with userfault support #5163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Secret Hiding] Add Linux patches with userfault support #5163
Conversation
          Codecov ReportAll modified and coverable lines are covered by tests ✅ 
 Additional details and impacted files@@                  Coverage Diff                   @@
##           feature/secret-hiding    #5163   +/-   ##
======================================================
  Coverage                  82.73%   82.73%           
======================================================
  Files                        251      251           
  Lines                      27522    27522           
======================================================
  Hits                       22771    22771           
  Misses                      4751     4751           
 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
  | 
    
This is to allow to keep the licence and readme files in the patches directory. Signed-off-by: Nikita Kalyazin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small suggestion to the patches/README.
Perhaps also call the directory kernel-patches to allow for other patches without mixing them.
Explicitly mention that Linux patches are distributed under the GPL-2.0 licence. Signed-off-by: Nikita Kalyazin <[email protected]>
Include the following patch series rebased on top of the v7 of "KVM: Mapping guest_memfd backed memory at the host for software protected VMs" (https://<lor>/kvm/[email protected]/, replace "<lor>" with "lore.kernel.org" in this and the following links): - v4 "Direct Map Removal for guest_memfd" (https://<lor>/kvm/[email protected]/), with fixups - v2 "KVM: Introduce KVM Userfault" (https://<lor>/kvm/[email protected]/) - v3 "KVM: guest_memfd: use write for population" (https://<lor>/kvm/[email protected]/) - v3 "KVM: guest_memfd: support for uffd minor" (https://<lor>/kvm/[email protected]/), with fixups After this change all patches are represented as plain text files, meaning no patches are required to be fetched via a lore link. Signed-off-by: Nikita Kalyazin <[email protected]>
This is to keep Linux patches separate in case we need to store some other patches at some point. Signed-off-by: Nikita Kalyazin <[email protected]>
          
 I renamed the directory to linux_patches. Thanks!  | 
    
90dca9a
      into
      
  
    firecracker-microvm:feature/secret-hiding
  
    
Changes
Reason
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
[ ] I have mentioned all user-facing changes inCHANGELOG.md.[ ] If a specific issue led to this PR, this PR closes the issue.[ ] When making API changes, I have followed theRunbook for Firecracker API changes.
[ ] I have tested all new and changed functionalities in unit tests and/orintegration tests.
[ ] I have linked an issue to every newTODO.rust-vmm.